Merged
Conversation
cooperlees
approved these changes
Jan 30, 2023
Collaborator
cooperlees
left a comment
There was a problem hiding this comment.
Thanks!
Wonder if we have auto updates enabled here, if not we should. I'll need to remember how to check for that.
Contributor
Author
|
@cooperlees I did see some other PRs (admittedly after opening this one!) indicating that PR updates may be enabled, e.g. #327. Not entirely sure on the lead times of those though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the isort pre-commit hook from 5.11.4 to 5.12.0.
On running the
pre-commit run --all-filescommand for the first time, I encountered an error. This seemed to be the same error that was fixed in this PR for isort, and the update fixes the error.