B906: ignore functions whose _fields attribute can't contain ast.AST subnodes#335
Merged
cooperlees merged 1 commit intoPyCQA:mainfrom Jan 18, 2023
Merged
Conversation
15d86d7 to
4206ad7
Compare
felix-hilden
left a comment
There was a problem hiding this comment.
Thanks for working on this so quickly 🙏 looking good apart from one thing below.
Collaborator
|
Will leave this for another release :) |
4206ad7 to
a0c50e5
Compare
a0c50e5 to
dd121c3
Compare
Contributor
Author
|
Rebased on top of main and removed |
cooperlees
approved these changes
Jan 18, 2023
Collaborator
cooperlees
left a comment
There was a problem hiding this comment.
Sound research, tests show it does what we want and if @felix-hilden is happy I am happy here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #330