PEP 621: Migrate more config into pyproject.toml#110
Merged
ssbarnea merged 3 commits intoPyCQA:mainfrom Sep 24, 2022
Merged
Conversation
for more information, see https://pre-commit.ci
ssbarnea
approved these changes
Sep 24, 2022
Member
ssbarnea
left a comment
There was a problem hiding this comment.
Good move! I know it will upset few people due pip problems with editable installs but that should not be good enough reason to prevent it.
Contributor
Author
|
Thx. Do you know of a good source of info on the editable installs issue? |
Member
|
@cclauss That is the infamous bug pypa/pip#7953 but I learnt to avoid it. Two workarounds: either use pyenv, and in that case you have user-level python, so you do not need to user PS. I will not make a release only with this patch as I do not find it worth a new release. OK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate configuration settings out of
setup.cfgintopyproject.tomlusingini2tomlto do the file conversion and then runvalidate-pyprojectto validate the results.flake8is not currently compatible withpyproject.tomlso migrate its config into.flake8.tool.setuptools.use-scm-versionwhich does not passvalidate-pyproject.