Adding logging.config.listen() plugin with examples#874
Merged
ericwb merged 5 commits intoPyCQA:mainfrom Apr 2, 2022
Merged
Conversation
ericwb
requested changes
Apr 2, 2022
Member
ericwb
left a comment
There was a problem hiding this comment.
Thanks for the additional plugin. I've noted some things to correct.
Also, you'll need to add a doc under doc/source/plugins/b612_......
raj3shp
commented
Apr 2, 2022
Contributor
Author
raj3shp
left a comment
There was a problem hiding this comment.
Thanks for the review. I've pushed the changes. Cheers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to contribute a plugin based on Python's security consideration regarding
logging.The actual issue (usage of
eval()) is whenlogging.config.fileConfigis called on an untrusted configuration file. However, it seems very obvious that configuration files are critical for security so will be write-protected to authorised users. The interesting attack vector is possible when an application exposes socket server to listen for configuration file from a network socket that a local attacker can exploit.So this plugin checks for usage of
logging.config.listenwithoutverifyargument which allows integrity checking or encryption/decryption capability to prevent abuse.(all tox tests passed)