While you're at it, you should enable "Allow app extension only API" so projects using this fwk in extensions won't display an extra warning.
Also I think an extra check for the existance of sharedApplication would be nice before calling it.

@pallzoltan allowing the app extension only API makes sense to my understanding but I don't quite believe the check to sharedApplication existence is needed as within its own definition its summarized stating:
"Returns the application instance, creating it if it doesn’t exist yet."

With this I would say it is safe in its usage unless you feel there is a need that the call to -[performSelector] should check beforehand that it exists.

I think you're reading the AppKit documentation. This block of code you've changed is wrapped in #if TARGET_OS_IPHONE.
To be honest, only today I've found out that share extensions also have access to an UIApplication object (if they manage to call sharedApplication) but I'm suspecting that's the application that started the share extension. So yeah, ignore the extra condition, the App Extension API flag would be very nice tho .)
Cheers!

@pallzoltan

While you're at it, you should enable "Allow app extension only API" so projects using this fwk in extensions won't display an extra warning.

Can you elaborate please? I am not sure I understand what part of code you refer to, or maybe to external configuration, please point me where. I am using CocoaPods so maybe we can add that flag to pod spec?

Also I think an extra check for the existance of sharedApplication would be nice before calling it.

App extensions can't access sharedApplication while GUI apps can. I don't see why we should check for its existence.

Can you elaborate please? I am not sure I understand what part of code you refer to, or maybe to external configuration, please point me where. I am using CocoaPods so maybe we can add that flag to pod spec?

It's just a flag (in Xcode UI it's under General). Checking this box makes the framework safe to use in an extension. Basically you're saying that you're not calling unsafe API from the extension (such as sharedApplication).
Without this flag, using the framework in a share extension causes a build-time warning, which is not very nice.

App extensions can't access sharedApplication while GUI apps can. I don't see why we should check for its existence.

It's more of a safety net after the "appex" extension check. If that ever changes (maybe a new target type which isn't an extension per se), it would catch any calls to a method that might not exist.

@pronebird Any luck updating this PR?

@pallzoltan I don't know how to implement what you suggest. Feel free to open a follow up PR.

If you merge my PR, we're ready to rumble .)

@pallzoltan nice! I have merged your commit into the PR's branch.

@mickeyreiss Would you be so kind and re-trigger Travis and have a look at this PR?

@pallzoltan the Travis build is failing due to Slather's argument option changes. I'm going to update it separately via the .yml file and get this merged in once the build is passing again.

Edit: Once PR #254 is merged in, I'll get this one taken care of.

@pallzoltan you can choose to rebase on top of the master branch now and it should resolve the CI build test.

cc @pronebird, thanks @toohotz

@toohotz @pallzoltan I have rebased the PR & it should be ready to go.

Great, I'd merge this but don't have write access, maybe @toohotz can.

Merged it for you.

Merged it for you.

@lwdupont Could you do a v3.1.8 release? I'd send a PR but can't create the tag.

@pallzoltan no worries, just released it.

@toohotz seems like you forgot to release on CocoaPods.

@pronebird Just released it a few minutes ago, sorry about that. @toohotz if you want me to add you to the cocoapods.org group who can release, let me know? (or are you in the list?)

@lwdupont feel free to add me on, don't believe I currently have access. 👍🏾

@toohotz I added you with the email github lists on your last checking (g----x@gmail.com) . That the correct one? You should have access now according to cocoapods.