-
Notifications
You must be signed in to change notification settings - Fork 732
Fixed issues on *excludingEdge: methods #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues on *excludingEdge: methods #212
Conversation
javitrujillo
commented
Mar 21, 2018
- After commit 04a3a0b it behaves wrong when receiving certain values like ALEdgeTop or ALEdgeBottom.
- After commit 04a3a0b it behaves wrong when receiving certain values like ALEdgeTop or ALEdgeBottom.
|
So looking into the issue more and also the #211 has issues of it own when I ran the demo 9 where it uses the So with the first issue, when you make a call for The second issue I came across purely because your PR made me look at the constraint logic I somewhat questioned also and actually seeing it in action I noticed that the logic doesn't seem to do what it was intended to. Easily tested this by first setting a fixed width on the green view in demo 9 by doing
I guess I might be digressing a little bit but usage of this API 90% of the time will take care of what most will use it for but for those that will accommodate RTL then we should let them be aware that they should probably create the constraints individually. |
a40bd76 to
967a969
Compare
…thod too to fix demo 9
|
Thank you for your response! I missed the FYI, we were having trouble with Now, it's fixed: |
toohotz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the additional changes. I will update the README per our discussion here so that users are aware that when the excluding edge is either ALEdgeTop or ALEdgeBottom that leading and trailing constraints will be used.
|
Thank you! |



