feat: Improve API for Encryption with a session key#331
Merged
Conversation
f344d7b to
1b2b9fa
Compare
lubux
commented
Apr 10, 2025
twiss
approved these changes
Apr 10, 2025
1b2b9fa to
63f920c
Compare
With RFC 9580, clients can encrypt data using AEAD with SEIPDv2 packets. However, SEIPDv2 packets are only compatible with PKESK v6 and SKESK v6 packets when the session key is encrypted using an OpenPGP certificate. This commit improves the API to reduce the risk of encrypting data with SEIPDv2 while using a session key encrypted in a packet version below v6. Specifically, the session key now includes an indicator of whether it is intended for AEAD use or not and affects the produced packets.
63f920c to
f0279bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With RFC 9580, clients can encrypt data using AEAD with SEIPDv2 packets. However, SEIPDv2 packets are only compatible with PKESK v6 and SKESK v6 packets when the session key is encrypted using an OpenPGP certificate.
This PR improves the API to reduce the risk of encrypting data with SEIPDv2 while using a session key encrypted in a packet version below v6. Specifically, the session key now includes an indicator of whether it is intended for AEAD use or not and affects the produced packets.