declare Builders type for builders()#9
Merged
marijnh merged 2 commits intoProseMirror:masterfrom Jul 22, 2022
Merged
Conversation
Until now, the only explicit return type of builder has been schema. Therefore, to use the builder in a TypeScript project, it had to be cast to any. This change provides a type that uses the schema and name of the builders argument to return the appropriate object.
Member
|
This code doesn't typecheck — you removed the |
Contributor
Author
|
fix to restore any casts. 2cdbc9b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change provides a type that uses the schema and name of the builders argument to return the appropriate object.
Motivation
Until now, the only explicit return type of builder has been schema.
Therefore, to use the builder in a TypeScript project, it had to be cast to any.
How Has This Been Tested?
I wanted to modify test-mark.ts, but this file could not reflect the changes because it is imported from npm, not the source code.
I confirmed that any here can be removed, along with this one: #10
I have also confirmed that the type is valid in the test code of a private project I am involved in.