Fixed projection function on ggd array#85
Merged
anchal-physics merged 1 commit intomasterfrom Jun 2, 2025
Merged
Conversation
project_prop_on_subset! function has been changed so that it does not restrict the input type anymore. The input type restriction was causing too much overhead in compilation (potentially a julia issue) but we aren't wining anything right now by fixing the type. The overhead comes when during compile time the script does not know the type of the input. This was happening in the second method which takes a string path from the ggd array to the property. Since this string path can be anything, the compiler goes into endless computation in pre-compile step and gets stuck without giving any warning or errors. I suspect another overflow issue similar to JuliaLang/julia#58129 fixed in JuliaLang/julia#58159 .
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 41.61% 41.70% +0.09%
==========================================
Files 4 4
Lines 632 633 +1
==========================================
+ Hits 263 264 +1
Misses 369 369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
project_prop_on_subset! function has been changed so that it does not restrict the input type anymore. The input type restriction was causing too much overhead in compilation (potentially a julia issue) but we aren't wining anything right now by fixing the type.
The overhead comes when during compile time the script does not know the type of the input. This was happening in the second method which takes a string path from the ggd array to the property. Since this string path can be anything, the compiler goes into endless computation in pre-compile step and gets stuck without giving any warning or errors. I suspect another overflow issue similar to JuliaLang/julia#58129 fixed in JuliaLang/julia#58159 .