[Minor] Improve error messaging for failed balance/approval checks#594
Merged
ryanio merged 2 commits intoProjectOpenSea:mainfrom Jul 4, 2024
Merged
Conversation
Signed-off-by: Frank Li <b439988l@gmail.com>
Signed-off-by: Frank Li <b439988l@gmail.com>
ryanio
approved these changes
Jul 4, 2024
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
+ Coverage 98.27% 98.67% +0.39%
==========================================
Files 35 35
Lines 14526 15651 +1125
Branches 660 690 +30
==========================================
+ Hits 14276 15444 +1168
+ Misses 245 202 -43
Partials 5 5 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's tough developer experience when prompted with the previous error message, resulting in quite some tinkling in my case, using npm link and logging things out to debug what's gone wrong in my set up. The change allows developers to find the cause of the balance/approval check fail at a glance.
Solution