(fix) Fix tip amount scaling in fulfillOrders#559
Merged
ryanio merged 4 commits intoProjectOpenSea:mainfrom May 30, 2024
Merged
(fix) Fix tip amount scaling in fulfillOrders#559ryanio merged 4 commits intoProjectOpenSea:mainfrom
ryanio merged 4 commits intoProjectOpenSea:mainfrom
Conversation
Signed-off-by: Frank Li <b439988l@gmail.com>
frankisawesome
commented
May 29, 2024
ryanio
reviewed
May 29, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 98.27% 98.41% +0.13%
==========================================
Files 35 35
Lines 14526 14955 +429
Branches 660 671 +11
==========================================
+ Hits 14276 14718 +442
+ Misses 245 232 -13
Partials 5 5 ☔ View full report in Codecov by Sentry. |
ryanio
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #558
Solution