Remove incorrect Signer type#460
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Jan 4, 2024
Merged
Conversation
Collaborator
|
nice catch, thank you! |
ryanio
approved these changes
Jan 4, 2024
Collaborator
|
released in v3.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request replaces the custom
Signertype with the standard type from ethers. This update is due to changes in the ethers v6 library, specifically the deprecation and subsequent removal of the_signTypedDatafunction. The existing customSignertype, which extendsethers.Signerwith_signTypedData, is now obsolete and incorrect.Solution
types.ts.seaport.tsimport to use the standardSignerdefinition.