Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
siwf/.github/workflows/deploy-pages-v1.yml
Lines 19 to 22 in b1e84a1
This deploy job still installs Node with matrix.node-version, but the strategy.matrix block was removed above, so the matrix context is undefined. GitHub will fail the workflow at evaluation time with an “Unrecognized named-value: 'matrix'” error and the pages deploy will not run.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We need to use npm v11.x, but we need to stick with earlier versions of node, which have 10.x
Solution
Pull in a version of the solution used with this frequency-chain PR
Steps to Verify:
CI should pass and install npm 11.