Merged
Conversation
aramikm
commented
Aug 22, 2024
| PROTOC := protoc | ||
| ifeq ($(UNAME), Darwin) | ||
| PROTOC = /opt/homebrew/opt/protobuf@27/bin/protoc | ||
| PROTOC = /opt/homebrew/opt/protobuf@21/bin/protoc |
Collaborator
Author
There was a problem hiding this comment.
Was showing that experimental issue which I thought it was solved. So had to role back to the previous version we were using.
JoeCap08055
approved these changes
Aug 23, 2024
Collaborator
JoeCap08055
left a comment
There was a problem hiding this comment.
all looks good--I had some concerns about doing a major version bump 1.1.x -> 2.0.0, but since anyone depending on the package will have to make a source change to pull from the new repo/published name anyway, I think it's fine.
+1 The Java package name change pushes it over the edge for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to update the repo to ProjectLibertyLabs
Closes #211
Changes
io.amplicajava toio.projectliberty@dsnp/graph-sdk->@projectlibertylabs/graph-sdkNODE_AUTH_TOKEN->NPM_AUTH_TOKENin GitHub Actions2.0.0amplica