Conversation
simulator/README.md
Outdated
| For being able to run the 20k users example the **maxPageId** on _frequency.json_ file should be changed to at least **64**. | ||
| We will update this value after it was updated un Frequency chain first. |
There was a problem hiding this comment.
In the other pending PR we're only bumping it to 32... should we tweak this test scenario?
There was a problem hiding this comment.
Also i updated to 64 in frequency.json and test failed, maybe we need to update in all configs or any specific config? from testing perspective
Should import data: InvalidPageId(17)
thread '' panicked at simulator/src/scenarios/common.rs:41:18:
Should import data: InvalidPageId(17)
There was a problem hiding this comment.
based on what is mentioned in the Readme you should only update frequency.json. I will add that you will need ot build after so that it rans the latest version
There was a problem hiding this comment.
@JoeCap08055 If we would like to test any private friendship scenarios we need at least 64 but since we don't have any use-cases on-chain, it doesn't make sense to set the chain value to 64 for now.
| use dsnp_graph_core::api::api_types::*; | ||
| use rand::{prelude::SliceRandom, thread_rng}; | ||
|
|
||
| pub fn execute_key_rotation_private_follow(state: &mut GlobalState, env: Environment) { |
There was a problem hiding this comment.
Hmm, this makes me think... I know we talked about a future enhancement to support a key rotation top-level method in the API, but I don't think we ever created an issue for it...
There was a problem hiding this comment.
We have force_recalculate_graphs that does key rotation on all pages also but currently we only do key rotation lazily whenever a page is modified.
There was a problem hiding this comment.
When running without the 20000 users pre-loaded data, I see lots of messages about
thread '<unnamed>' panicked at simulator/src/init.rs:145:18:
error exporting updates with 6099 connections: GraphIsFull
When running with the 20000 pre-load file, I see the same errors, but the process finishes pretty quickly.
Both runs end with the same result:
make: *** [run-sim] Error 101
Steps taken:
- Edit frequency.json to change max page id to 64
- Put
20000_simulation_state.binin project root - Run
make build-sim ; make run-sim
saraswatpuneet
left a comment
There was a problem hiding this comment.
left some nit
- ran fine, i had to update maxPageId in all 3 configs but not sure which is right one
- we can update the doc to reflect the above
Found my error; re: @saraswatpuneet 's comment about building the SDK first. I had a stale build from an older branch. |
JoeCap08055
left a comment
There was a problem hiding this comment.
- Built SDK and ran simulation
lgtm
Goal
The goal of this PR is to allow us to do some large scale verification and stress testing.
Closes #197
Discussion
Computed Scenarios