Skip to content

bugfix: fixed next page id calculation#195

Merged
aramikm merged 3 commits intomainfrom
fix_next_page_id_bug
Apr 3, 2024
Merged

bugfix: fixed next page id calculation#195
aramikm merged 3 commits intomainfrom
fix_next_page_id_bug

Conversation

@aramikm
Copy link
Copy Markdown
Collaborator

@aramikm aramikm commented Apr 3, 2024

Goal

The goal of this PR is fix the bug which exports only the last page instead of all of them when more than 1 page is created via adding connections.

Closes #194

Checklist

  • updated versions
  • Tests added

@aramikm aramikm requested a review from saraswatpuneet April 3, 2024 23:14
@aramikm aramikm requested a review from JoeCap08055 April 3, 2024 23:19
}

#[test]
fn get_next_available_page_should_include_updated_pages() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯


#[test]
#[timeout(3000)]
#[timeout(30000)]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timed out in CI

Suggested change
#[timeout(30000)]
#[timeout(60000)]

@aramikm aramikm merged commit 0d03e91 into main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]

3 participants