Expose commit/rollback via bridge apis#193
Merged
JoeCap08055 merged 8 commits intomainfrom Apr 2, 2024
Merged
Conversation
Collaborator
Author
|
I'll sync this from main once #191 is merged |
Contributor
|
Should we do this after the stable release? |
aramikm
approved these changes
Apr 2, 2024
Collaborator
aramikm
left a comment
There was a problem hiding this comment.
Looks good. Thanks for adding this. A couple of nits and I think we might also need a small test on java side to ensure jni works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to expose GraphSDK's commit/rollback functionality to the Bridge APIs (currently only available via native Rust API)
disable_auto_commitflag toActionOptions, haveapply_actionshonor itCloses #192
Checklist