fix: use npm install --ignore-scripts to avoid native build in release#7474
Merged
DennisOSRM merged 1 commit intomasterfrom Apr 12, 2026
Merged
fix: use npm install --ignore-scripts to avoid native build in release#7474DennisOSRM merged 1 commit intomasterfrom
DennisOSRM merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the monthly release workflow to avoid triggering native module builds during the publish job, relying instead on prebuilt binaries produced by the tag-triggered CI workflow.
Changes:
- Adds a dependency installation step using
--ignore-scriptsbeforenpm publishto prevent running native build-related lifecycle scripts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| exit 1 | ||
|
|
||
| - name: Install dependencies (skip native build scripts) | ||
| run: npm install --ignore-scripts |
There was a problem hiding this comment.
Use npm ci --ignore-scripts instead of npm install --ignore-scripts in this workflow. npm ci is deterministic (strictly respects package-lock.json) and avoids potentially rewriting the lockfile or resolving newer dependency versions during a release publish job.
Suggested change
| run: npm install --ignore-scripts | |
| run: npm ci --ignore-scripts |
The release workflow should not attempt to build native modules. The native binaries are built separately by the CI job triggered by the tag push and uploaded to the release assets. Using --ignore-scripts skips the 'install' script (which tries to build native modules) while still installing dependencies needed for npm publish, including husky for the prepare script. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8740c3d to
569369c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow should not attempt to build native modules. The native binaries are built separately by the CI job triggered by the tag push and uploaded to the release assets.
Using --ignore-scripts skips the 'install' script (which tries to build native modules) while still installing dependencies needed for npm publish, including husky for the prepare script.
This fixes the issue where npm install would fail trying to download prebuilt binaries that haven't been built yet.