Skip to content

fix: configure git identity in release action before tagging#7471

Merged
DennisOSRM merged 1 commit intomasterfrom
fix/release-git-identity
Apr 12, 2026
Merged

fix: configure git identity in release action before tagging#7471
DennisOSRM merged 1 commit intomasterfrom
fix/release-git-identity

Conversation

@DennisOSRM
Copy link
Copy Markdown
Collaborator

Problem

The release action was failing with:

Committer identity unknown
fatal: empty ident name (for <runner@...>) not allowed

Root Cause

The 'Create git tag' step requires git identity to be configured, but the identity config only happens in the conditional 'Commit version update' step. When that step is skipped (e.g., when version is unchanged), git identity is never set.

Solution

Configure git identity directly in the 'Create git tag' step before creating the annotated tag. This ensures git identity is always available regardless of whether the commit step runs.

Changes

  • Added git config user.name and git config user.email to 'Create git tag' step
  • Uses github-actions[bot] identity (consistent with commit step)

Fixes the failure in the monthly release workflow.

The 'Create git tag' step was failing with 'Committer identity unknown' because
git identity was only configured in the conditional 'Commit version update' step.
When that step was skipped (no version changes), git identity was never set.

Now git config is called directly in the 'Create git tag' step to ensure
git identity is always available for annotated tag creation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 12, 2026 12:13
@DennisOSRM DennisOSRM enabled auto-merge (squash) April 12, 2026 12:18
@DennisOSRM DennisOSRM disabled auto-merge April 12, 2026 12:18
@DennisOSRM DennisOSRM merged commit 63fba02 into master Apr 12, 2026
25 checks passed
@DennisOSRM DennisOSRM deleted the fix/release-git-identity branch April 12, 2026 12:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the monthly release GitHub Actions workflow can always create an annotated git tag by configuring the git committer identity even when the version-bump commit step is skipped.

Changes:

  • Configure user.name / user.email in the Create git tag step to prevent “Committer identity unknown” failures.
  • Align tag creation identity with the existing Commit version update bot identity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 124 to 128
- name: Create git tag
run: |
git config user.name "github-actions[bot]"
git config user.email "github-actions[bot]@users.noreply.github.com"
git tag -a "${{ steps.version.outputs.tag }}" -m "Release ${{ steps.version.outputs.version }}"
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git identity config is now duplicated between the conditional "Commit version update" step and this always-run tag step. Consider moving the config into a dedicated always-run step (or making the scope explicit with --local) so there’s a single place to keep user.name/user.email consistent.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants