Replace node-cmake w/ CMake.js. Fix Windows Node.js build failure for Node.js v22+ (dropped x86 support)#7451
Merged
DennisOSRM merged 12 commits intomasterfrom Apr 8, 2026
Merged
Conversation
…S.cmake Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/960667a2-de96-4d80-a070-43d4d3f1350e Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/960667a2-de96-4d80-a070-43d4d3f1350e Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing error handling for user inputs
Fix Windows Node.js build failure for Node.js v22+ (dropped x86 support)
Apr 7, 2026
Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/69ccfadd-6da6-4159-b571-e33e961de4d2 Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/69ccfadd-6da6-4159-b571-e33e961de4d2 Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
… cmake_ar Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/69ccfadd-6da6-4159-b571-e33e961de4d2 Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/0f8976eb-1c19-4718-8b5e-d71bd4acc32a Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
…erated node.lib on MSVC Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/2d5446cd-c947-44a1-b4aa-64f500997857 Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Collaborator
|
@copilot apply changes based on the comments in this thread |
…h cmake-js@^8 requirement Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/120b1d09-2070-4639-ba42-97b825f28ad8 Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DennisOSRM
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-undefined dynamic_lookuptonode_osrmtarget on Apple platforms/Wl,-z,origin: guard it to Linux-only (elseif(NOT WIN32))node.libpath: always overrideCMAKE_JS_LIBwith the locally-generated path on MSVCRESULT_VARIABLE/ERROR_VARIABLE+FATAL_ERRORtoprint-cmakejs-libfallback probeRESULT_VARIABLE/ERROR_VARIABLE+FATAL_ERRORtoprint-cmakejs-srcfallback probeengines.nodeinpackage.jsonto^20.17.0 || >=22.9.0to align with cmake-js@^8