Merged
Conversation
Collaborator
|
Is there a chance we could separate this into two prs, one for reformatting and another for the functional change? |
Contributor
Author
|
The functional change is contained entirely in the file |
Collaborator
|
Could we do this in two PRs? The first changes formatting and the second the functional change. I know this is a bit cumbersome, but provides more clarity during debugging. |
DennisOSRM
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update NodeJS tests
The last point enables testing from a
cmake --installdirectory, so as to catch missing dynamic libraries, wrong RPATH etc.