Add missing <optional> and <string> includes, order alphabetically#7385
Merged
DennisOSRM merged 2 commits intodluxen/remove-superfluous-boost-includesfrom Feb 27, 2026
Merged
Conversation
6 tasks
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
DennisOSRM
approved these changes
Feb 27, 2026
Copilot stopped work on behalf of
DennisOSRM due to an error
February 27, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #7384 to add missing standard library includes and ensure alphabetical ordering in
parameters_parser.hpp.Changes:
#include <optional>(file usesstd::optional)#include <string>(file usesstd::string)<optional>,<string>,<type_traits>This makes the header self-contained and robust against future include changes in dependencies.