Reenable temporarily disabled CI jobs#7357
Conversation
1e47593 to
57d6f8b
Compare
There was a problem hiding this comment.
Pull request overview
Re-enables the previously commented-out GitHub Actions CI matrix job conan-linux-debug-asan-ubsan in osrm-backend.yml after PR #7309 was merged, restoring sanitizer coverage in CI.
Changes:
- Un-comments / reintroduces the
conan-linux-debug-asan-ubsanjob configuration in the build matrix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| continue-on-error: false | ||
| node: 20 | ||
| runs-on: ubuntu-24.04 | ||
| BUILD_TYPE: Release | ||
| CCOMPILER: clang-18 | ||
| CXXCOMPILER: clang++-18 | ||
| ENABLE_CONAN: ON | ||
| ENABLE_SANITIZER: ON | ||
| ENABLE_LTO: OFF |
There was a problem hiding this comment.
YAML indentation is inconsistent for this matrix entry: the keys under - name: conan-linux-debug-asan-ubsan (e.g., continue-on-error, node, runs-on, etc.) are indented one space less than the other matrix.include items. This will break YAML parsing / cause the workflow to fail to load. Align these keys to the same indentation level used by other entries (two spaces further than the - name: line).
| continue-on-error: false | |
| node: 20 | |
| runs-on: ubuntu-24.04 | |
| BUILD_TYPE: Release | |
| CCOMPILER: clang-18 | |
| CXXCOMPILER: clang++-18 | |
| ENABLE_CONAN: ON | |
| ENABLE_SANITIZER: ON | |
| ENABLE_LTO: OFF | |
| continue-on-error: false | |
| node: 20 | |
| runs-on: ubuntu-24.04 | |
| BUILD_TYPE: Release | |
| CCOMPILER: clang-18 | |
| CXXCOMPILER: clang++-18 | |
| ENABLE_CONAN: ON | |
| ENABLE_SANITIZER: ON | |
| ENABLE_LTO: OFF |
| - name: conan-linux-debug-asan-ubsan | ||
| continue-on-error: false | ||
| node: 20 | ||
| runs-on: ubuntu-24.04 | ||
| BUILD_TYPE: Release | ||
| CCOMPILER: clang-18 |
There was a problem hiding this comment.
The matrix entry name conan-linux-debug-asan-ubsan conflicts with BUILD_TYPE: Release. If this is intended to be a Release sanitizer build, consider renaming the entry to avoid confusion (and misleading cache keys/artifact labels). If it's meant to be a Debug sanitizer build, switch BUILD_TYPE accordingly.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # ENABLE_LTO: OFF | ||
| - name: clang-18-debug | ||
| continue-on-error: false | ||
| node: |
There was a problem hiding this comment.
The 'node' field is missing a value. Looking at other similar job configurations in this file, this field should either have a node version number (e.g., 'node: 22') or be omitted entirely. An empty value after the colon may cause issues in the workflow execution.
| node: | |
| node: 22 |
| OSRM_CONNECTION_RETRIES: 10 | ||
| OSRM_CONNECTION_EXP_BACKOFF_COEF: 1.5 |
There was a problem hiding this comment.
The environment variables OSRM_CONNECTION_RETRIES and OSRM_CONNECTION_EXP_BACKOFF_COEF are being used in this job configuration, but according to PR #7309 (mentioned in the PR description), these variables were retired and are no longer supported. These lines should be removed to align with the changes made in PR #7309.
| OSRM_CONNECTION_RETRIES: 10 | |
| OSRM_CONNECTION_EXP_BACKOFF_COEF: 1.5 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
#7309 was merged