Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses memory leaks detected by ASAN in the Beast-based HTTP server implementation. The changes focus on proper shutdown synchronization and preventing reference cycles in asynchronous handlers.
Changes:
- Added a wait loop in the
Stop()method to ensure the io_context has fully stopped before returning - Changed async handler captures from
shared_ptrtoweak_ptrinDoAccept()to prevent reference cycles
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dbc8830 to
8f485b0
Compare
DennisOSRM
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
As noted by @MarcelloPerathoner ASAN reports some leaks with the new beast code. This is cause by two things:
shared_ptrin the payloads of the async handler functions. Even if there is no busy connection they sit in the queue with a handle. This changes it toweak_ptrwhich promotes toshared_ptrif we actually start execution.Tasklist
Requirements / Relations
#7328