Conversation
5 tasks
4bd324a to
7786c8d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where allowing 8 exclude class combinations made it impossible to differentiate invalid class combinations from cases where all classes are used. The solution reduces the maximum number of excludable classes from 8 to 7, ensuring the MSB (most significant bit) of the ClassData uint8_t type remains available to mark invalid class data. Additionally, the PR corrects a spelling typo throughout the codebase, changing INAVLID_CLASS_DATA to INVALID_CLASS_DATA.
Key Changes:
- Reduced
MAX_EXCLUDABLE_CLASSESfrom 8 to 7 andMAX_CLASS_INDEXfrom 7 to 6 - Fixed typo:
INAVLID_CLASS_DATA→INVALID_CLASS_DATAacross the codebase - Added explanatory comments about the 7-class limit
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
include/extractor/class_data.hpp |
Updated constants to limit max excludable classes to 7 (was 8) and max class index to 6 (was 7), corrected typo INAVLID→INVALID, added explanatory comment |
include/extractor/profile_properties.hpp |
Corrected typo INAVLID_CLASS_DATA → INVALID_CLASS_DATA |
include/util/exclude_flag.hpp |
Corrected typo INAVLID_CLASS_DATA → INVALID_CLASS_DATA |
unit_tests/extractor/intersection_analysis_tests.cpp |
Corrected typo INAVLID_CLASS_DATA → INVALID_CLASS_DATA in test annotations |
CHANGELOG.md |
Added changelog entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DennisOSRM
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Allow for 8 exclude combinations makes it impossible to differentiate invalid class combinations from the ones where all classes are used.
Tasklist
Requirements / Relations
Replaces #7282