Disable array bounds warning until GCC is fixed#7317
Merged
Conversation
Contributor
|
Hi @TheMarex have you tried wrapping the That would keep the warning enabled for OSRM's own code. |
56b6520 to
0a040ca
Compare
Member
Author
|
@afarber Excellent suggestion, didn't know GCC supported that. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR works around a false-positive GCC array-bounds warning in the sol2 library by suppressing the warning using compiler diagnostic pragmas. This addresses build failures mentioned in issue #7129.
- Adds
#pragma GCC diagnosticdirectives around the sol2 include to suppress array-bounds warnings - Updates CHANGELOG.md to document the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/extractor/scripting_environment_lua.hpp | Adds GCC diagnostic pragmas to suppress false-positive array-bounds warnings around sol2 include |
| CHANGELOG.md | Documents the compilation error fix under the Build section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e5f897a to
a6041ab
Compare
DennisOSRM
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
There are various issues around failing builds because of a false-positive in sol2. Simple "fix" is do disable the array bounds check for now. Workaround for #7129
Tasklist