Fix std::is_trivial deprecation and clang-tidy warnings#7291
Merged
DennisOSRM merged 6 commits intoProject-OSRM:masterfrom Jan 11, 2026
Merged
Fix std::is_trivial deprecation and clang-tidy warnings#7291DennisOSRM merged 6 commits intoProject-OSRM:masterfrom
DennisOSRM merged 6 commits intoProject-OSRM:masterfrom
Conversation
1df3f4f to
b944f9f
Compare
…ix clang-tidy misc-redundant-expression error
b944f9f to
92b9e71
Compare
TheMarex
approved these changes
Jan 9, 2026
DennisOSRM
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7245
PR #7248 missed two
std::is_trivialinstances that use the::valuesyntax (infingerprint.hppandedge_based_graph_factory.hpp).Also, combining multiple type traits with
&&triggers a false positive from clang-tidy'smisc-redundant-expressioncheck. This PR splits all combinedstatic_assertconditions into separate statements to fix the CI failure.Changes
std::is_trivialwithstd::is_trivially_default_constructible+std::is_trivially_copyablestatic_assertconditions to avoid clang-tidy warningTasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?