Fix Node.js binding path to match node-pre-gyp versioning#7277
Merged
DennisOSRM merged 5 commits intoProject-OSRM:masterfrom Jan 3, 2026
Merged
Fix Node.js binding path to match node-pre-gyp versioning#7277DennisOSRM merged 5 commits intoProject-OSRM:masterfrom
DennisOSRM merged 5 commits intoProject-OSRM:masterfrom
Conversation
Contributor
Author
|
Hi @DennisOSRM and @SiarheiFedartsou please take a look at my fix |
|
Thanks for this @afarber. I wasted so much time trying to understand what was going on! |
43baee5 to
05a1f30
Compare
Contributor
Author
|
Hi @DennisOSRM please consider merging this fix and then releasing the 6.0.1 version |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Node.js binding path to align with node-pre-gyp versioning conventions by updating the binding directory from lib/binding to lib/binding_napi_v8.
Key changes:
- Updated BINDING_DIR in CMakeLists.txt to use
lib/binding_napi_v8and added directory creation during CMake configuration - Removed the
lib/binding_napi_v8symlink that previously pointed tolib/binding - Updated all references across code, documentation, CI scripts, and configuration files to use the new path
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/nodejs/CMakeLists.txt | Updates BINDING_DIR variable to new path and adds file(MAKE_DIRECTORY) command to ensure directory exists |
| lib/index.js | Updates require path to load native binding from new location |
| src/nodejs/node_osrm.cpp | Updates documentation comments with corrected binary paths |
| docs/nodejs/api.md | Updates API documentation examples with new binding path |
| package.json | Updates nodejs-tests script to reference new binary location |
| scripts/ci/run_benchmarks.sh | Updates benchmark script to use new node_osrm.node path |
| scripts/ci/node_package.sh | Updates packaging script to check binary in new location |
| .github/workflows/osrm-backend.yml | Updates commented-out test commands with new binary paths |
| .gitignore | Updates ignored directory from lib/binding to lib/binding_napi_v8 |
| lib/binding_napi_v8 | Removes symlink that previously pointed to binding directory |
| CHANGELOG.md | Adds entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DennisOSRM
approved these changes
Jan 2, 2026
Collaborator
DennisOSRM
left a comment
There was a problem hiding this comment.
Good sleuthing finding this fix. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7272 by:
lib/bindingtolib/binding_napi_v8to align with node-pre-gyp's versioningconventions
file(MAKE_DIRECTORY)to create the binding directory during CMake configurationTasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?