Reduce the number of MSVC warnings in CI workflow builds on Windows#7254
Merged
DennisOSRM merged 6 commits intoProject-OSRM:masterfrom Oct 15, 2025
Merged
Conversation
Suppress informational warnings while keeping bug-indicating ones Fix type safety warnings in xor_fast_hash.hpp and contracted_edge_container.hpp
Contributor
Author
|
Hi @SiarheiFedartsou and @DennisOSRM currently the Build log for conan-windows-release-node is very large, sometimes even not viewable in a web browser. Please review my PR, it reduces the number of MSVC compiler warnings significantly |
DennisOSRM
approved these changes
Sep 25, 2025
Contributor
Author
|
Hi @SiarheiFedartsou and @DennisOSRM please consider merging the PR |
Contributor
Author
|
Hi @SiarheiFedartsou and @DennisOSRM please consider merging the PR It is a small change, but makes the windows CI build logs readable again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the #7253 by:
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?