Improve lint rules, update npm packages, add pre-commit hook#7234
Merged
DennisOSRM merged 8 commits intoProject-OSRM:masterfrom Sep 6, 2025
Merged
Improve lint rules, update npm packages, add pre-commit hook#7234DennisOSRM merged 8 commits intoProject-OSRM:masterfrom
DennisOSRM merged 8 commits intoProject-OSRM:masterfrom
Conversation
Contributor
Author
|
Hi @DennisOSRM please review my PR. I have also tried to update the api.md Wiki but I cannot submit the changed file because that repo is archived. Here is the updated file as attachment: api.md Here is the updated file in my forked repo: https://github.com/afarber/node-osrm/blob/patch-1/docs/api.md Maybe you have an idea how to update the Wiki properly with the file. Finally, please consider discarding your own PR #7177 because it is covered by this PR. |
DennisOSRM
approved these changes
Sep 6, 2025
Collaborator
DennisOSRM
left a comment
There was a problem hiding this comment.
Nice! Love the husky pre commit hook to enforce style. Thx!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fix the issues #7228 and #7229 by:
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?