Skip to content

Convert remaining scripts from CommonJS to ESM format and use flatbuffers npm package#7233

Merged
DennisOSRM merged 6 commits intoProject-OSRM:masterfrom
afarber:7227-use-flatbuffers-npm
Sep 5, 2025
Merged

Convert remaining scripts from CommonJS to ESM format and use flatbuffers npm package#7233
DennisOSRM merged 6 commits intoProject-OSRM:masterfrom
afarber:7227-use-flatbuffers-npm

Conversation

@afarber
Copy link
Copy Markdown
Contributor

@afarber afarber commented Sep 4, 2025

Issue

Fix #7227 by:

  • Convert remaining scripts from CommonJS to ESM format and rename *.cjs to *.js
  • Use flatbuffers npm package
  • Convert var to let/const
  • Add few comments explaining the purpose of each *.js file

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@afarber
Copy link
Copy Markdown
Contributor Author

afarber commented Sep 5, 2025

@DennisOSRM please review

Copy link
Copy Markdown
Collaborator

@DennisOSRM DennisOSRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean change. 👍🏼

@DennisOSRM DennisOSRM merged commit bec4947 into Project-OSRM:master Sep 5, 2025
21 checks passed
@afarber afarber deleted the 7227-use-flatbuffers-npm branch September 5, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace custom flatbuffers.cjs with npm package

2 participants