Skip to content

Mini roundabouts and traffic calming penalties#534

Closed
philkingston wants to merge 1 commit intoProject-OSRM:masterfrom
philkingston:travel_time_accuracy
Closed

Mini roundabouts and traffic calming penalties#534
philkingston wants to merge 1 commit intoProject-OSRM:masterfrom
philkingston:travel_time_accuracy

Conversation

@philkingston
Copy link
Copy Markdown

I have been trying to get an accurate travel duration output from OSRM. I have noticed that various road items such as mini roundabouts and speed bumps don't get considered. These nodes can often affect the speed at which a vehicle travels and frequently influences a route. For example, a lot of people are deterred from using certain roads with speed bumps.

This branch makes the system consider mini roundabouts and traffic calming nodes when calculating a duration for a route. Each of the respective nodes have penalty scores added to the lua script. The code change is a very straightforward extension of the traffic light code.

What do you think? In my evaluation, it certainly seems to improve the accuracy of the route times.

Phil

@emiltin
Copy link
Copy Markdown
Contributor

emiltin commented Dec 11, 2012

good stuff. however, i think we should consider a more flexible solution, where the lua script calculates or sets the delay in the node function, see #527. otherwise we will soon get too many tags hardcoded in the osrm code. what about gates, bicycle_barrier, etc?

@philkingston
Copy link
Copy Markdown
Author

Couldn't agree more. In fact, I was trying to think of more nodes that would incur penalties, but didn't think about the ones you just listed. A penalty-per-node would definitely be the more flexible solution. I'll start looking into it.

@DennisOSRM
Copy link
Copy Markdown
Collaborator

Huh, this totally fell through the cracks. I will merge this manually in the coming days and do some tests. Thanks, again.

@TheMarex
Copy link
Copy Markdown
Member

In general we should allow penalties for arbitrary nodes (just allowing traffic lights is overly restrictive). Since this PR is outdated I did cut a ticket for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants