Merged
Conversation
12fccae to
dffa01f
Compare
Member
There was a problem hiding this comment.
-DCMAKE_BUILD_TYPE=Release ..?
8b04d6f to
3b3cbd4
Compare
Member
Author
|
@daniel-j-h @MoKob if you can do a quick review of the changes today that would be great. Want to merge this as soon as possible. |
There was a problem hiding this comment.
Shouldn't the header guard reflect the header? I'd love to even include the hierarchy of folders, e.g. CONTRACTOR_CONTRACTOR_HPP in this case to make sure that we can handle files of same names in different folders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor OSRM to expose real libraries for
extract,contractanddatastore.