Fix delete / remove or add autoload for options which have dot in their name#42
Merged
Fix delete / remove or add autoload for options which have dot in their name#42
Conversation
|
Test on Playground |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came in https://wordpress.org/support/topic/litespeed-autoload/
The issue is comes from LiteSpeed options having dot in their name, for example
litespeed.admin_display.messagesand it is partly valid.AAAOO plugin option name to generate the ID of the row (HTML element) for that option in the table, but this is invalid CSS ID selector:
tr#option_litespeed.admin_display.messagesSo what happens is that option is deleted, but the element can not be found in the table which triggers a JS error that user shared.
Also, looks like LiteSpeed options are recreated on page load so once user refreshes the page option is again displayed and looks like nothing happened.
This PR replaces the dots with
_(maybe we can use different character for replacement, just needs to make valid CSS selector?) and fixes the issue. Manipulation is done only in JS, doesn't need to be adjusted.