Add Cirrus CI; add --force_fail and --fail_fast options to example.c#2
Add Cirrus CI; add --force_fail and --fail_fast options to example.c#2dankegel wants to merge 0 commit intoProgramMax:developfrom
Conversation
|
Chris, feel like configuring cirrus support on your branch to see it in action? |
d1464cc to
2d1f3a8
Compare
|
I know I suggested sending the pull requests to my branch, but I think I should now suggest the opposite. What I meant was individual small changes that we wanted to see in that initial upstream pull request. But I feel like these things should be a separate pull request upstream, since they add separate functionality. What do you think? I think it is better to show these to the greater community. Here, I think it won't get the visibility and I shouldn't be the gatekeeper. (Again, when I suggested here, I meant for changes going into that initial pull request. Since the discussion was happening upstream, there was visibility and I just wanted to make sure your suggestions were properly credited to you in the pull request.) |
|
I'll rebase onto your branch until that lands, and then onto develop.
I'm sure it'll work out.
- Dan
…On Mon, May 25, 2020 at 2:34 PM Chris Blume ***@***.***> wrote:
I know I suggested sending the pull requests to my branch, but I think I
should now suggest the opposite.
What I meant was individual small changes that we wanted to see in that
initial upstream pull request. But I feel like these things should be a
separate pull request upstream, since they add separate functionality.
What do you think? I think it is better to show these to the greater
community. Here, I think it won't get the visibility and I shouldn't be the
gatekeeper. (Again, when I suggested here, I meant for changes going into
that initial pull request. Since the discussion was happening upstream,
there was visibility and I just wanted to make sure your suggestions were
properly credited to you in the pull request.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJXYEF4OJKSPDMPJWBMNTRTLP6TANCNFSM4NGBWQOQ>
.
|
Changes to test/example.c:
(see example at https://github.com/dankegel/zlib/pull/3/checks?check_run_id=690339991)
Other changes: