src/server/api/routers/mobile/deviceBrands.ts (1)

11-42: ⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Router should delegate to DeviceBrandsRepository instead of building Prisma queries directly.

This router constructs the where clause inline and queries ctx.prisma.deviceBrand.findMany directly. The DeviceBrandsRepository.list() method (reviewed in this same PR) implements identical filtering logic via buildWhereClause(). The main deviceBrandsRouter correctly delegates to the repository.

This violates the coding guideline: "Do not put raw Prisma queries or business logic in routers" and "Routers in src/server/api/routers/ are thin orchestration layers that handle auth context, schema-validated input, repository/service calls, and response formatting."

Additionally, lines 15-16 use string literals 'cpu' and 'gpu' for comparisons, which may violate the guideline: "do not use string literals for enum values in application code (routers)."

♻️ Refactor to use repository

  get: mobilePublicProcedure.input(GetDeviceBrandsSchema).query(async ({ ctx, input }) => {
-   const { search, category, limit, sortField, sortDirection } = input ?? {}
-
-   const where: Prisma.DeviceBrandWhereInput = {
-     ...(search && { name: { contains: search, mode: 'insensitive' } }),
-     ...(category === 'cpu' && { cpus: { some: {} } }),
-     ...(category === 'gpu' && { gpus: { some: {} } }),
-   }
-
-   const orderBy: Prisma.DeviceBrandOrderByWithRelationInput[] = []
-
-   if (sortField && sortDirection) {
-     switch (sortField) {
-       case 'name':
-         orderBy.push({ name: sortDirection })
-         break
-       case 'devicesCount':
-         orderBy.push({ devices: { _count: sortDirection } })
-         break
-     }
-   }
-
-   // Default ordering if no sort specified
-   if (!orderBy.length) {
-     orderBy.push({ name: 'asc' })
-   }
-
-   return ctx.prisma.deviceBrand.findMany({
-     where,
-     include: { _count: { select: { devices: true } } },
-     orderBy,
-     take: limit,
-   })
+   const repository = new DeviceBrandsRepository(ctx.prisma)
+   return repository.list(input ?? {})
  }),

You'll need to add the import:

+import { DeviceBrandsRepository } from '`@/server/repositories/device-brands.repository`'

As per coding guidelines, routers in src/server/api/routers/ are thin orchestration layers that delegate to repositories, and do not put raw Prisma queries or business logic in routers.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/server/api/routers/mobile/deviceBrands.ts` around lines 11 - 42, The
router is building Prisma queries inline; replace that logic by delegating to
the repository: import and call DeviceBrandsRepository.list (which uses
buildWhereClause) instead of constructing where/orderBy and calling
ctx.prisma.deviceBrand.findMany directly; pass the validated input and ctx (or
ctx.prisma) as the repository expects, remove the inline where/orderBy/take
logic, and ensure you stop using string literals 'cpu'/'gpu' by using the shared
enum/type used by DeviceBrandsRepository for the category field so the router
relies entirely on the repository for query semantics.