Skip to content

Remove unused Stop Killing Games popup#424

Merged
Producdevity merged 2 commits into
stagingfrom
fix/remove-stop-killing-games-popup
Jun 4, 2026
Merged

Remove unused Stop Killing Games popup#424
Producdevity merged 2 commits into
stagingfrom
fix/remove-stop-killing-games-popup

Conversation

@Producdevity

@Producdevity Producdevity commented Jun 4, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Description

Removes the unused StopKillingGamesPopup component and the dead storage/analytics code that only supported that popup.

Fixes #404

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor
  • Other (please describe):

How Has This Been Tested?

  • Local build
  • Lint
  • Typecheck
  • Unit tests
  • Manual testing

Ran:

  • git diff --check
  • ./node_modules/.bin/eslint src/data/storageKeys.ts src/lib/analytics/actions.ts src/lib/analytics/analytics.ts
  • ./node_modules/.bin/prettier --check src/data/storageKeys.ts src/lib/analytics/actions.ts src/lib/analytics/analytics.ts

Screenshots (if applicable)

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • Documentation changes are not needed for this change
  • I have checked that all checks (lint, typecheck, test) pass

Notes for reviewers

No StopKillingGamesPopup references remain under src.

Summary by CodeRabbit

  • Chores
    • Removed two informational popups (beta welcome and campaign petition) that previously displayed to users.
    • Cleared their dismissal persistence and related analytics tracking.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b4c1603f-224a-42c0-8e4b-73e6ee606c76

📥 Commits

Reviewing files that changed from the base of the PR and between 192f004 and a2c508a.

📒 Files selected for processing (3)
  • src/components/popups/BetaWarningPopup.tsx
  • src/components/popups/index.ts
  • src/data/storageKeys.ts
💤 Files with no reviewable changes (3)
  • src/components/popups/index.ts
  • src/components/popups/BetaWarningPopup.tsx
  • src/data/storageKeys.ts

Walkthrough

This PR removes the StopKillingGamesPopup component and fully cleans up its supporting infrastructure: the dismissal state key from storage configuration, the analytics action constants for tracking engagement, and the event tracking functions that reported user interactions with the popup.

Changes

StopKillingGamesPopup Removal

Layer / File(s) Summary
Supporting infrastructure cleanup
src/data/storageKeys.ts, src/lib/analytics/actions.ts, src/lib/analytics/analytics.ts		 Storage key, analytics action constants (STOP_KILLING_GAMES_CTA, STOP_KILLING_GAMES_DISMISSED), and engagement event functions (stopKillingGamesDismissed, stopKillingGamesCTA) are removed.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—removing the unused StopKillingGamesPopup component—and is clear and specific.
Description check ✅ Passed The description follows the template structure with issue reference, change type, testing performed, and checklist completion. All required sections are adequately filled.
Linked Issues check ✅ Passed The PR fully addresses issue #404 by removing the StopKillingGamesPopup component and all associated dead code (storage keys and analytics), as requested.
Out of Scope Changes check ✅ Passed All changes are directly scoped to removing the StopKillingGamesPopup and its dependencies; the removal of BetaWarningPopup appears related to cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-stop-killing-games-popup
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/remove-stop-killing-games-popup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercel Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
emuready Ready Ready Preview, Comment Jun 4, 2026 2:56pm

Request Review

@Producdevity Producdevity merged commit 9f68bb6 into staging Jun 4, 2026
8 checks passed
@Producdevity Producdevity deleted the fix/remove-stop-killing-games-popup branch June 4, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: evaluate whether StopKillingGamesPopup is still needed

1 participant

@Producdevity