fix(markdown): remove generated inline code backticks#368
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR reorganizes markdown components by moving ChangesMarkdown Component Module Reorganization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/globals.css (1)
4-4:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winTailwind v4 compatibility:
@tailwindcss/typographymatches the current@pluginsetup.
@tailwindcss/typographyis supported on Tailwind CSS v4 using the CSS-first@plugin "@tailwindcss/typography"registration style, which aligns with thesrc/app/globals.cssusage. Reports using@tailwindcss/typography@0.5.16on v4 are “mostly works”; the remaining risk is edge-case selector/variant interactions, so validate typography rendering for your main content patterns.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/globals.css` at line 4, The current use of the CSS-first Tailwind plugin registration "`@plugin` '`@tailwindcss/typography`';" in globals.css is compatible with Tailwind v4, so leave the `@plugin` declaration as-is (do not switch to the v3-style plugin config), but run a quick visual check of components that use prose/typography to catch any edge-case selector or variant interactions; reference the `@plugin` line in src/app/globals.css and validate pages that use the typography classes to ensure rendering is correct.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/app/globals.css`:
- Line 4: The current use of the CSS-first Tailwind plugin registration "`@plugin`
'`@tailwindcss/typography`';" in globals.css is compatible with Tailwind v4, so
leave the `@plugin` declaration as-is (do not switch to the v3-style plugin
config), but run a quick visual check of components that use prose/typography to
catch any edge-case selector or variant interactions; reference the `@plugin` line
in src/app/globals.css and validate pages that use the typography classes to
ensure rendering is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #282
Inline code in Markdown-rendered content was showing extra backticks because Tailwind Typography adds
code::beforeandcode::aftercontent by default.This overrides those pseudo-elements inside
.prose, so descriptions, comments, and other Markdown content render inline code without the extra visible characters.No dependencies.
Type of change
How Has This Been Tested?
Checked:
pnpm lint:fixpnpm lintpnpm typespnpm test src/utils/markdown.test.ts src/utils/markdown.node.test.tspnpm test.prose code::before/.prose code::afteroverride after Typography's default backtick ruleScreenshots (if applicable)
N/A
Checklist
Summary by CodeRabbit
Refactor
Tests