Skip to content

FOUR-19110: [40531] changes on screen are not reflected in ongoing cases#1716

Merged
ryancooley merged 2 commits intonextfrom
bugfix/FOUR-19110
Sep 29, 2024
Merged

FOUR-19110: [40531] changes on screen are not reflected in ongoing cases#1716
ryancooley merged 2 commits intonextfrom
bugfix/FOUR-19110

Conversation

@eiresendez
Copy link
Copy Markdown
Contributor

@eiresendez eiresendez commented Sep 27, 2024

Issue & Reproduction Steps

This PR is part of: ProcessMaker/processmaker#7427

Current behavior

  • Changes applied on a screen and published are only reflected in new cases. in 4.10 the changes were reflected in new and also ongoing cases

Expected behavior

  • Change should be reflected in ongoing cases.

Solution

  • Added a version parameter (screen_version) to screen URLs, generated based on the latest published id of the screen.
  • This approach forces the browser to treat each updated published screen as a new resource, preventing the use of outdated cached versions.

How to Test

  • Verify that screen updates generate new URLs with different version parameters, ensuring that changes are correctly fetched.
  • Test across different browsers to confirm that old cached versions are not used.

Related Tickets & Packages

ci:next

… updates are reflected

- Added a version parameter to screen URLs based on the last modified id.
- Ensures that changes in the screen trigger a new URL, bypassing cached versions.
- Prevents stale data by forcing the browser to fetch the updated resource when changes occur.
@cypress
Copy link
Copy Markdown

cypress bot commented Sep 27, 2024

screen-builder    Run #1369

Run Properties:  status check passed Passed #1369  •  git commit 7f68a0e583: FOUR-19110: [40531] changes on screen are not reflected in ongoing cases
Project screen-builder
Branch Review bugfix/FOUR-19110
Run status status check passed Passed #1369
Run duration 07m 15s
Commit git commit 7f68a0e583: FOUR-19110: [40531] changes on screen are not reflected in ongoing cases
Committer Eleazar Resendez
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 296
View all changes introduced in this branch ↗︎

@eiresendez eiresendez requested a review from caleeli September 27, 2024 17:29
@ryancooley ryancooley merged commit 3b55605 into next Sep 29, 2024
@ryancooley ryancooley deleted the bugfix/FOUR-19110 branch September 29, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants