Skip to content

FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates#1700

Merged
sanjacornelius merged 11 commits intoepic/FOUR-18012from
task/FOUR-18315
Sep 16, 2024
Merged

FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates#1700
sanjacornelius merged 11 commits intoepic/FOUR-18012from
task/FOUR-18315

Conversation

@mcraeteisha
Copy link
Copy Markdown
Contributor

@mcraeteisha mcraeteisha commented Sep 13, 2024

Task

Ticket: FOUR-18315

This PR introduces comprehensive Cypress tests for the Screen Templates Panel in screen-builder and adds template-fetching functionality to screen-builder.

The tests check that:

  • My Templates are displayed when the 'My Templates' button is clicked in the Screen Templates Panel
  • Shared Templares are displayed when the 'Shared Templates' button is clicked in the Screen Templates Panel

This PR also refactors the handling of templates data, and the show/close functionality for the Screen Templates Panel.

How to Test

  1. Go to branch task/FOUR-18315 in screen-builder and processmaker.
  2. Run npx open cypress and npm run dev in your screen-builder terminal.
  3. Run tests for ScreenTemplateSection.spec.js in Cypress.
    • All tests should pass.

ci:next

Core PR

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cypress
Copy link
Copy Markdown

cypress bot commented Sep 13, 2024

screen-builder    Run #1331

Run Properties:  status check passed Passed #1331  •  git commit 3709c79e8e: FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates
Project screen-builder
Branch Review task/FOUR-18315
Run status status check passed Passed #1331
Run duration 08m 51s
Commit git commit 3709c79e8e: FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates
Committer Teisha McRae
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 301
View all changes introduced in this branch ↗︎

@sanjacornelius sanjacornelius merged commit c25ce9a into epic/FOUR-18012 Sep 16, 2024
@sanjacornelius sanjacornelius deleted the task/FOUR-18315 branch September 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants