Skip to content

Update readme and add namespace config#7833

Merged
nolanpro merged 3 commits intofeature/FOUR-20257from
feature/FOUR-21074
Dec 18, 2024
Merged

Update readme and add namespace config#7833
nolanpro merged 3 commits intofeature/FOUR-20257from
feature/FOUR-21074

Conversation

@gproly
Copy link
Copy Markdown
Contributor

@gproly gproly commented Dec 17, 2024

Descripción

I already

  • Set the namespace in the config (needed by cloudops)
  • removed unused code
  • updated the readme
  • made grafana development docker compose anonymous (no username/password needed)

We need to

  • Add the logic to MetricService to support Metrics::counter and Metrics::guage (and histogram the same way)
  • Use the metric name (first argument) as the 2nd argument (description) if not provided
  • Use config('app.prometheus_namespace') to set the namespace
  • use the library’s getOrRegister*** methods
  • Remove any additional unused code

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-21074

@gproly gproly requested a review from nolanpro December 17, 2024 23:17
@processmaker-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@nolanpro nolanpro merged commit f433669 into feature/FOUR-20257 Dec 18, 2024
@nolanpro nolanpro deleted the feature/FOUR-21074 branch December 18, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants