FOUR-20504 enhance test coverage for settings functionality before adding cache#7766
Merged
caleeli merged 3 commits intoepic/FOUR-20326from Nov 27, 2024
Merged
FOUR-20504 enhance test coverage for settings functionality before adding cache#7766caleeli merged 3 commits intoepic/FOUR-20326from
caleeli merged 3 commits intoepic/FOUR-20326from
Conversation
b9ff70e to
6f48021
Compare
caleeli
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Complete the Test coverage of Settings by adding at least the following one:
Solution
How to Test
php artisan test --filter 'SettingLogInOptionsTest|SettingSessionControlTest|SettingAuthTest'Related Tickets & Packages
FOUR-20504
Code Review Checklist