Fix UUID Generation Error for Collection Records#6351
Merged
ryancooley merged 1 commit intodevelopfrom Mar 7, 2024
Merged
Conversation
The collection package already handles generating the collection record uuid upon creation.
|
estebangallego
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0.0% Coverage on New Code
0.0% Duplication on New Code
This PR addresses a log error related to UUID generation when creating collection records. The error occurred due to the duplication of
generateUuidmethod in the HasUuid file and in the collections package RecordObserver file. While this error did not affect functionality, it cluttered the logs unnecessarily.Solution
generateUuidmethod in theHasUuidtrait to prevent UUID generation for collection records.uuidproperty is set on the object before attempting to generate a UUID.How to Test
Related Tickets & Packages
Code Review Checklist