Skip to content

Fix Incorrect Status Displayed After Completing "Re-run Wizard" Request#6205

Merged
ryancooley merged 1 commit intonextfrom
observation/FOUR-14143
Feb 14, 2024
Merged

Fix Incorrect Status Displayed After Completing "Re-run Wizard" Request#6205
ryancooley merged 1 commit intonextfrom
observation/FOUR-14143

Conversation

@sanjacornelius
Copy link
Copy Markdown
Contributor

@sanjacornelius sanjacornelius commented Feb 9, 2024

Issue & Reproduction Steps

This PR resolves an issue where the incorrect status "cancel" was displayed instead of "completed" after completing the "Re-run Wizard" request. The issue stemmed from the incorrect usage of the $this.close method, which updated the request status to "cancel" when the modal was closed by the user. The solution involves replacing the close method with the hide method for the modal.

Solution

  • Implement .hide() method for Re-run Wizard modal

How to Test

  1. Ensure you have a Guided Template Process created.
  2. Within the Launchpad of the process, select "Re-run Wizard."
  3. Progress through the wizard and complete the request.
  4. Once completed, navigate to "Requests -> All Requests."
  5. Ensure the request displays the proper status "completed."

Related Tickets & Packages

ci:next
ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 now it shows as "Completed".

Screenshot 2024-02-09 at 14-55-47 My Requests - ProcessMaker

@tokensPM
Copy link
Copy Markdown

tokensPM commented Feb 9, 2024

QA server K8S was successfully deployed https://ci-402bc476f5.engk8s.processmaker.net

@ryancooley ryancooley merged commit 472026b into next Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants