FOUR-10278: Display and parse correct date/time for "Last Login" user column#6195
Merged
ryancooley merged 2 commits intonextfrom Feb 9, 2024
Merged
FOUR-10278: Display and parse correct date/time for "Last Login" user column#6195ryancooley merged 2 commits intonextfrom
ryancooley merged 2 commits intonextfrom
Conversation
|
|
QA server K8S was successfully deployed https://ci-1e8f732ff3.engk8s.processmaker.net |
josechirivella
approved these changes
Feb 8, 2024
eiresendez
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0.0% Coverage on New Code
0.0% Duplication on New Code
Issue
The "Last Login" column for the user list found in the admin dashboard was incorrectly parsing the datetime causing it to show a different date and time than when the user actually logged in.
Reproduction Steps
Solution
The
loggedin_atattribute had to be cast todatetimein theProcessMaker\Models\Usermodel.How to Test
With the fix, the correct date and time should now display for the "Last Login" column in the user listing.
CICD
ci:deploy
ci:next
Related Tickets & Packages
FOUR-10278
Code Review Checklist