Fix BuildScriptExecutor Failure on Importing Script Executors#6132
Merged
ryancooley merged 3 commits intonextfrom Feb 1, 2024
Merged
Fix BuildScriptExecutor Failure on Importing Script Executors#6132ryancooley merged 3 commits intonextfrom
ryancooley merged 3 commits intonextfrom
Conversation
|
QA server K8S was successfully deployed https://ci-41896da9de.engk8s.processmaker.net |
|
9 tasks
nolanpro
approved these changes
Feb 1, 2024
nolanpro
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0.0% Coverage on New Code
0.0% Duplication on New Code
Issue & Reproduction Steps
This PR resolves a failure in the
BuildScriptExecutorwhen importing a script executor. The issue was caused by aModelNotFoundExceptionoccurring when the job was triggered during a database transaction.To fix this, the queue connection configuration option
afterCommitwas added to the dispatch method. This ensures that the job is triggered after the database transaction is completed, preventing theModelNotFoundException.ci:next
ci:deploy
How to Test
Setup
Testing:
Example Script:
3.Run the process.
Related Tickets & Packages
Code Review Checklist