Skip to content

Observation/FOUR-13815: Ellipsis options are not shown if the screen is reduced in process#6114

Merged
ryancooley merged 2 commits intonextfrom
observation/FOUR-13815
Jan 30, 2024
Merged

Observation/FOUR-13815: Ellipsis options are not shown if the screen is reduced in process#6114
ryancooley merged 2 commits intonextfrom
observation/FOUR-13815

Conversation

@agustinbusso
Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso commented Jan 30, 2024

Issue & Reproduction Steps

Steps to reproduced:

  • Go to process
  • Click on ellipsis of any process
  • Shrink the screen a little
  • View the ellipsis options

Current Behavior:
You can no longer see all the ellipsis options.

Expected Behavior:
You should be able to see all the options even if the screen is reduced.

Solution

  • Added max height and scrollbars to the menu.

Working video

Screen.Recording.2024-01-30.at.10.44.34.mov

How to Test

Open the ellipsis menu and verify a scrollbar is added for larger menus

Related Tickets & Packages

  • FOUR-13815

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@processmaker-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@gustavobascope gustavobascope self-requested a review January 30, 2024 14:15
Copy link
Copy Markdown
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No observations, the fix works with small resolutions

@tokensPM
Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-480985bf88.engk8s.processmaker.net

@ryancooley ryancooley merged commit 99d73c1 into next Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants