-
Notifications
You must be signed in to change notification settings - Fork 8
WebSocket-based restore #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As discussed yesterday, this direction looks good to me. |
|
Tests added |
|
besides "there's something up with dependencies" which I have yet to figure out, i think this is ready for review @exarkun (I think the trick is to find an Autobahn with the right testing fixes that is old enough to keep the rest happy?) |
This avoids a `resolvelib.ResolutionTooDeep` during dependency resolution, for some reason. We also switch to getting cryptography from nixpkgs because there is a new enough version there to satisfy the new constraint in autobahn and it's harder to get cryptography from an sdist or wheel. pypi-deps-db only has sdist metadata up to cryptography 3.3.2 after which cryptography switched to setuptools_rust which breaks mach-nix's metadata scanner for sdists. pypi-deps-db has lots of wheel metadata but cryptography distributes abi3 wheels which it seems mach-nix doesn't entirely support (it can't figure out that though they have the cp36 tag they should be usable by later pythons).
Then we don't need to mutate them later or even offer a mutation API.
Assert against both message lists at the same time so we can see all of the unexpected values instead of only one.
exarkun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I pushed some changes and also left some inline comments.
Codecov Report
@@ Coverage Diff @@
## main #410 +/- ##
==========================================
- Coverage 96.32% 96.23% -0.10%
==========================================
Files 63 63
Lines 7428 7508 +80
Branches 1004 1013 +9
==========================================
+ Hits 7155 7225 +70
- Misses 204 210 +6
- Partials 69 73 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@exarkun
The client side of this might look like: