Coy: Set z-index to make shadows visible in coloured table cells#3161
Coy: Set z-index to make shadows visible in coloured table cells#3161RunDevelopment merged 2 commits intoPrismJS:masterfrom
Conversation
|
I hate Coy so much... Thanks for the PR @hoonweiting! Unfortunately, this bug has (almost) nothing to do with Toolbar. Coy is a strong and independent theme and doesn't need no plugin to be bugged. It seems like Coy's shadows just don't work when you set the background color of the parent element. So that means that your PR won't really fix the problem. My idea would be to remove What do you think @hoonweiting?
I wouldn't worry about that too much. By the nature of CSS, (almost) every fix is also a breaking change. |
|
@RunDevelopment Yeah, I like your idea much better! Should I send in a separate PR for the Toolbar fix? Coy has its charms, and to be fair, I almost didn't notice the missing shadows the first time round either! And I just noticed something else on the front page of the website:
I just filed an issue for it: #3162. I wouldn't have noticed this if I hadn't happened to have the Coy theme selected and decided to scroll down on the front page for no real reason. Also, I can't believe there's a whole guide out there on semantic versioning! Interesting stuff, thanks! |
That would be great. Thanks!
Good find and it's not even Coy's fault. |
|
Nice. Thank you @hoonweiting! |
Just realised that the problem of Coy's shadows disappearing in coloured table cells still exists, at least on Prism's website.
This PR sets the z-index of
preto 1, and.toolbarto 2, so the shadows are visible. I'm not super sure if this is the way to go (mainly idk if this will break people's stuff on their own sites if they update their theme, but if they have a problem they can fix it on their end?), but I guess this change is along the same lines as the previewers popup from a while back so it's fine?