Update Scheme syntax for real numbers#3159
Merged
RunDevelopment merged 1 commit intoPrismJS:masterfrom Oct 23, 2021
Merged
Conversation
Contributor
Author
|
I'm not sure why some builds failed. |
Member
|
The change itself LGTM. The build failed because you also have to commit the minified scheme file. Run Also, could you please add a test for this? You can learn more about tests here. |
According to R7RS spec, you can use different mnemonics for the scientific notation that indicated the precision of the number.
Contributor
Author
|
Added min.js file and unit tests. |
RunDevelopment
approved these changes
Oct 23, 2021
Member
|
Thank you for contributing @jcubic! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to R7RS spec, you can use different mnemonics
for the scientific notation that indicated the precision of the number.
Just found about this in section 6.2.4 of R7RS spec where it says:
I was testing in Chicken, Kawa, Gambit, and Gauche implementations all of them support different precision mnemonics for real numbers.